What you have is a power inserter, for a pre-amp. It should be indoors as it is not weather proof.
The box is, as has been said earlier, fine. Yes there are better boxes, but what you have should do the trick since it was doing the trick before.
My antenna setup. However, the bottom antenna is...